SkPDF: PDFStream has-a not is-a PDFDict

SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003

Committed: https://skia.googlesource.com/skia/+/fa25106f02f26d7a149cfe57c1d4756372e0755c

[hal.canary, 2016-07-28 13:01:38]

Description was changed from

==========
SkPDF: PDFStream has-a not is-a PDFDict

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
==========

to

==========
SkPDF: PDFStream has-a not is-a PDFDict

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

[hal.canary, 2016-07-28 13:02:33]

Description was changed from

==========
SkPDF: PDFStream has-a not is-a PDFDict

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

to

==========
SkPDF: PDFStream has-a not is-a PDFDict

SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

[hal.canary, 2016-07-28 13:02:55]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:03:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-28 13:08:19]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-07-28 13:08:20]

PTAL

[commit-bot: I haz the power, 2016-07-28 13:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:14:17]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[hal.canary, 2016-07-28 13:14:46]

Description was changed from

==========
SkPDF: PDFStream has-a not is-a PDFDict

SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

to

==========
SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

[hal.canary, 2016-07-28 15:27:51]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 15:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:32:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hal.canary, 2016-07-28 15:48:13]

Description was changed from

==========
SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

to

==========
SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

[hal.canary, 2016-07-28 15:50:34]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2016-07-28 15:50:42]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-07-28 15:50:47]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-07-28 15:50:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:56:04]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[hal.canary, 2016-07-28 15:59:51]

Patchset #2 (id:60001) has been deleted

[hal.canary, 2016-07-28 15:59:59]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 16:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:11:50]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-07-29 16:06:05]

lgtm

https://codereview.chromium.org/2190883003/diff/80001/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/2190883003/diff/80001/src/pdf/SkPDFTypes.h#ne...
src/pdf/SkPDFTypes.h:327: /** \class SkPDFSharedStream
name in comment doesn't match name of class?

[hal.canary, 2016-07-29 16:31:29]

https://codereview.chromium.org/2190883003/diff/80001/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/2190883003/diff/80001/src/pdf/SkPDFTypes.h#ne...
src/pdf/SkPDFTypes.h:327: /** \class SkPDFSharedStream
On 2016/07/29 16:06:05, tomhudson wrote:
> name in comment doesn't match name of class?

Done.

[hal.canary, 2016-07-29 16:31:34]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-07-29 16:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/2190883003/#ps100001
(title: "2016-07-29 (Friday) 12:30:20 EDT")

[commit-bot: I haz the power, 2016-07-29 16:31:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:13:21]

Description was changed from

==========
SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
==========

to

==========
SkPDF: PDFStream has-a not is-a PDFDict

Motivation:
SkPDFStream and SkPDFSharedStream now work the same.

Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003

Committed:
https://skia.googlesource.com/skia/+/fa25106f02f26d7a149cfe57c1d4756372e0755c
==========

[commit-bot: I haz the power, 2016-07-29 17:13:22]

Committed patchset #3 (id:100001) as
https://skia.googlesource.com/skia/+/fa25106f02f26d7a149cfe57c1d4756372e0755c