Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2190863003: [gn] Add required sanitizer blacklist files. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add required sanitizer blacklist files. Splitt of CL: https://codereview.chromium.org/2188693002/#ps100001 Switching to GN is blocked on test errors. These files are required for compilation and allow looking into the test errors locally. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/0f62a0e7aa62c9e9b3f2f17599f36a25cf61664e Cr-Commit-Position: refs/heads/master@{#38130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A tools/memory/asan/blacklist.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/memory/tsan_v2/ignores.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. Files with their text copied from chromium.
4 years, 4 months ago (2016-07-28 10:06:32 UTC) #3
vogelheim
lgtm
4 years, 4 months ago (2016-07-28 10:57:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190863003/1
4 years, 4 months ago (2016-07-28 11:01:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 11:03:37 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 11:06:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f62a0e7aa62c9e9b3f2f17599f36a25cf61664e
Cr-Commit-Position: refs/heads/master@{#38130}

Powered by Google App Engine
This is Rietveld 408576698