Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2190833002: [turbofan] Eliminate redundant CheckString based on types. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate redundant CheckString based on types. If the input to a CheckString is already a String, then the check is redundant. R=epertoso@chromium.org Committed: https://crrev.com/f8ded1125f4c0b4492fcf9114bd6f1ea558033b2 Cr-Commit-Position: refs/heads/master@{#38118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-28 03:27:49 UTC) #1
Benedikt Meurer
Hey Enrico, Here's a working version for CheckString. Please take a look. Thanks, Benedikt
4 years, 4 months ago (2016-07-28 03:28:36 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-07-28 08:03:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190833002/1
4 years, 4 months ago (2016-07-28 08:55:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 08:56:57 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 08:58:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8ded1125f4c0b4492fcf9114bd6f1ea558033b2
Cr-Commit-Position: refs/heads/master@{#38118}

Powered by Google App Engine
This is Rietveld 408576698