Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2179)

Unified Diff: build/toolchain/gcc_link_wrapper.py

Issue 2190813002: Add LC_ALL=C to gcc linker wrappers to speed up links (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: target linker step onnly Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/gcc_solink_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/gcc_link_wrapper.py
diff --git a/build/toolchain/gcc_link_wrapper.py b/build/toolchain/gcc_link_wrapper.py
index c701c1b99c1a55efa42e73eb33b874d830a5d0d7..c589fe330d4c10926aa1411af00a1942ee56f7f4 100755
--- a/build/toolchain/gcc_link_wrapper.py
+++ b/build/toolchain/gcc_link_wrapper.py
@@ -11,6 +11,7 @@ does not have a POSIX-like shell (e.g. Windows).
"""
import argparse
+import os
import subprocess
import sys
@@ -47,8 +48,10 @@ def main():
help='Linking command')
args = parser.parse_args()
- # First, run the actual link.
- result = subprocess.call(CommandToRun(args.command))
+ # Work-around for gold being slow-by-default. http://crbug.com/632230
+ fast_env = dict(os.environ)
+ fast_env['LC_ALL'] = 'C'
+ result = subprocess.call(CommandToRun(args.command), env=fast_env)
if result != 0:
return result
« no previous file with comments | « no previous file | build/toolchain/gcc_solink_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698