Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2190793002: make use of the use_gio gn arg (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of the use_gio gn arg BUG=632297 Committed: https://crrev.com/491846845617b9e94ee2636b28a117b60be4e4cf Cr-Commit-Position: refs/heads/master@{#409204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mostyn Bramley-Moore
@phajdan: please take a look at this tiny cleanup.
4 years, 4 months ago (2016-07-27 23:17:03 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 4 months ago (2016-08-02 09:47:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190793002/1
4 years, 4 months ago (2016-08-02 14:57:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 16:18:14 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 16:19:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/491846845617b9e94ee2636b28a117b60be4e4cf
Cr-Commit-Position: refs/heads/master@{#409204}

Powered by Google App Engine
This is Rietveld 408576698