ash/common/system/tray/system_tray_item.cc - Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/tray/system_tray_item.cc

Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable hiding animation; restoring volume does not notify UI Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/system/tray/system_tray.cc ('K') | « ash/common/system/tray/system_tray_item.h ('k') | ash/common/system/tray/system_tray_notifier.h » ('j') | chromeos/audio/cras_audio_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/tray/system_tray_item.cc

diff --git a/ash/common/system/tray/system_tray_item.cc b/ash/common/system/tray/system_tray_item.cc

index 59902be67dc17bf9ce3c178144c3d6398d414cce..f03a7e5ff33d348f011ece8ee5203e121bfa0545 100644

--- a/ash/common/system/tray/system_tray_item.cc

+++ b/ash/common/system/tray/system_tray_item.cc

@@ -57,8 +57,8 @@ void SystemTrayItem::SetDetailedViewCloseDelay(int for_seconds) {

system_tray()->SetDetailedViewCloseDelay(for_seconds);

}

-void SystemTrayItem::HideDetailedView() {

- system_tray()->HideDetailedView(this);

+void SystemTrayItem::HideDetailedView(bool hide_animation) {

Daniel Erat 2016/07/28 22:20:40 same comment about confusing parameter name

Qiang(Joe) Xu 2016/07/28 23:15:57 Done.

+ system_tray()->HideDetailedView(this, hide_animation);

}

void SystemTrayItem::ShowNotificationView() {