Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2553)

Unified Diff: ash/wm/power_button_controller.h

Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove OnDidTakeScreenshot; clean code Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/power_button_controller.h
diff --git a/ash/wm/power_button_controller.h b/ash/wm/power_button_controller.h
index 970ddab86dc8ce1bec159fa736c39dad267c7513..f932fb446ae25888896e2a8e2c7743d5d7a393d0 100644
--- a/ash/wm/power_button_controller.h
+++ b/ash/wm/power_button_controller.h
@@ -80,6 +80,8 @@ class ASH_EXPORT PowerButtonController
private:
friend class test::PowerButtonControllerTest;
+ void TakingScreenshot();
Daniel Erat 2016/07/28 04:45:00 rename to TakeScreenshot and add a comment describ
Qiang(Joe) Xu 2016/07/28 20:25:03 done by deleting this method.
+
// Are the power or lock buttons currently held?
bool power_button_down_;
bool lock_button_down_;
@@ -87,6 +89,9 @@ class ASH_EXPORT PowerButtonController
// True when the volume down button is being held down.
bool volume_down_pressed_;
+ // Volume to be restored after a maximize mode screenshot.
+ int saved_volume_percent_;
Daniel Erat 2016/07/28 04:45:00 nit: rename this to something like volume_percent_
Qiang(Joe) Xu 2016/07/28 20:25:02 Done.
+
// Has the screen brightness been reduced to 0%?
bool brightness_is_zero_;

Powered by Google App Engine
This is Rietveld 408576698