ash/common/system/chromeos/network/tray_sms.cc - Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/tray_sms.cc

Issue 2190773002: Fix Volume slider is captured in screenshot done in touchview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: several updates included Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/system/chromeos/network/tray_sms.cc

diff --git a/ash/common/system/chromeos/network/tray_sms.cc b/ash/common/system/chromeos/network/tray_sms.cc

index 95c61518f3e813f18ef210cd39866524d42f74b7..42473968aa082314db5dafdd553528f0c7d0f575 100644

--- a/ash/common/system/chromeos/network/tray_sms.cc

+++ b/ash/common/system/chromeos/network/tray_sms.cc

@@ -411,7 +411,7 @@ void TraySms::Update(bool notify) {

if (default_)

default_->SetVisible(false);

if (detailed_)

- HideDetailedView();

+ HideDetailedView(true);

Daniel Erat 2016/08/01 21:10:06 nit: mind documenting the argument with an inline

Qiang(Joe) Xu 2016/08/01 22:56:47 Done.

HideNotificationView();

} else {

if (default_) {

« no previous file with comments | « no previous file | ash/common/system/tray/system_tray.h » ('j') | ash/common/system/tray/system_tray.h » ('J')