Add network setup code to BlimpClientContextImpl

blimp/client/core/blimp_client_context_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/blimp_client_context_impl.h"
 
+#include "base/message_loop/message_loop.h"
+#include "base/threading/thread.h"
 #include "blimp/client/public/blimp_client_context_delegate.h"
 #include "blimp/client/public/contents/blimp_contents.h"
 #include "blimp/client/test/test_blimp_client_context_delegate.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blimp {
 namespace client {
 namespace {
 
 TEST(BlimpClientContextImpl, CreatedBlimpContentsGetsHelpersAttached) {

[Kevin M, 2016/08/02 19:55:41]

Strongly prefer using TEST_F, even if the class body is empty.

[nyquist, 2016/08/02 21:47:04]

In this CL https://codereview.chromium.org/1912153004/ between patch set 1 and 2
and the file 
blimp/common/blob_cache/id_util_unittest.cc, the opposite advice was given,
which is why I did it that way. I don't feel strongly myself though.

Anyway, for this CL, I moved the thread setup and shutdown to a test-class, so
now it should all be fine.

-  BlimpClientContextImpl blimp_client_context;
+  base::MessageLoop message_loop;
+
+  // Start IO thread.
+  base::Thread io_thread("BlimpTestIO");
+  base::Thread::Options options;
+  options.message_loop_type = base::MessageLoop::TYPE_IO;
+  io_thread.StartWithOptions(options);
+
+  BlimpClientContextImpl blimp_client_context(io_thread.task_runner());
   TestBlimpClientContextDelegate delegate;
   blimp_client_context.SetDelegate(&delegate);
 
+  BlimpContents* attached_blimp_contents = nullptr;
+
+  EXPECT_CALL(delegate, AttachBlimpContentsHelpers(testing::_))
+      .WillOnce(testing::SaveArg<0>(&attached_blimp_contents))
+      .RetiresOnSaturation();
+
   std::unique_ptr<BlimpContents> blimp_contents =
       blimp_client_context.CreateBlimpContents();
   DCHECK(blimp_contents);
-  DCHECK_EQ(blimp_contents.get(),
-            delegate.GetBlimpContentsWithLastAttachedHelpers());
+  DCHECK_EQ(blimp_contents.get(), attached_blimp_contents);
 }
 
 }  // namespace
 }  // namespace client
 }  // namespace blimp