Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 2190743003: [turbofan] Remove eager frame state from shift operations. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_contrib-2191883002
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from shift operations. This removes the frame state input representing the before-state from nodes having any shift operator. Any lowering that woult insert number conversions of the inputs has already been disabled when deoptimization is enabled, because the frame state layout is no longer known. R=epertoso@chromium.org BUG=v8:5021 Committed: https://crrev.com/dc505196e6483e43028ddad949189d5394d7084e Cr-Commit-Position: refs/heads/master@{#38194}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 9 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Starzinger
Follow-up to one of your CLs you have in flight. So excited to get rid ...
4 years, 4 months ago (2016-07-28 16:47:46 UTC) #3
epertoso
lgtm
4 years, 4 months ago (2016-07-29 07:30:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190743003/40001
4 years, 4 months ago (2016-08-01 08:08:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 08:30:37 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 08:34:04 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc505196e6483e43028ddad949189d5394d7084e
Cr-Commit-Position: refs/heads/master@{#38194}

Powered by Google App Engine
This is Rietveld 408576698