Chromium Code Reviews Chromium Code Reviews
Issue
219073002:
design-mode-spellcheck-off.html is always passing (Closed)
Descriptiondesign-mode-spellcheck-off.html is always passing
There are two reasons for the positive result of the test.
Firstly, assuming that the misspelled word has been already typed,
placing the caret at the beginning or in the middle of the word
does not guarantee to be spellchecked. The patch moves the selection
out of the misspelled words.
Secondly, MockSpellCheck::misspelledWords[] contatins 'asd' not 'asdf'.
As a result, 'asdf' could not be recognized as misspelled word.
Consistent with editing/selection/13804.html, design-mode-spellcheck-off.html
relies on 'asd' as well.
<body spellcheck=false> causes that the bug was not revealed.
To be more reliable, the test now contains two test cases when
spellcheck attribute is off and on.
Due to js-test.js adds some HTML elements inside the BODY, the misspelled
phrase was moved into separated div element. It allows to check spelling marker
on desired element instead of whole body.
Inspired by WebKit changeset http://trac.webkit.org/changeset/164101.
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170858
Patch Set 1 #
Total comments: 1
Patch Set 2 : verify 'asd' (not 'asdf') since MockSpellCheck::misspelledWords[] contatins it #
Messages
Total messages: 8 (0 generated)
|
||||||||||||||||||||||||||||
