Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2190713004: GN: fix mac build again (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: fix mac build again Hoping to land these using the other GN bots as trybots. Don't know what magic was letting us get to webp's headers yesterday on Linux. Might have been using /usr/include's ? The other change is the difference between some setups using #define SK_BUILD_FOR_MAC and others #define SK_BUILD_FOR_MAC 1. We want either to mean "we're Mac". BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190713004 Committed: https://skia.googlesource.com/skia/+/0634317cbe50f5dd21e7e78da59cb2dba0edcae4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/libwebp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
mtklein_C
DM does now link and run on Mac too.
4 years, 4 months ago (2016-07-28 13:40:27 UTC) #4
jcgregorio
lgtm
4 years, 4 months ago (2016-07-28 13:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190713004/1
4 years, 4 months ago (2016-07-28 16:57:51 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:58:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0634317cbe50f5dd21e7e78da59cb2dba0edcae4

Powered by Google App Engine
This is Rietveld 408576698