Require sanity: sort kwargs expectations. NOT OPTIONAL.

Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org

Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/6c5c35640c9ea1dbc5e1976bc3a44b543339388f

[tandrii(chromium), 2016-07-27 20:02:51]

Description was changed from

==========
Rename sorted_kwargs parameter and add handy expectation generator

R=sergiyb@chromium.org
BUG=
==========

to

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

[tandrii(chromium), 2016-07-27 20:05:09]

Description was changed from

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

to

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

[tandrii(chromium), 2016-07-27 20:05:10]

Description was changed from

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

to

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

[tandrii(chromium), 2016-07-27 20:05:41]

PTAL

Yes, I'll will fix all the stupid tests :(

[tandrii(chromium), 2016-07-27 20:47:22]

Patchset #1 (id:1) has been deleted

[tandrii(chromium), 2016-07-27 20:47:31]

Patchset #4 (id:80001) has been deleted

[tandrii(chromium), 2016-07-27 20:47:40]

Patchset #2 (id:40001) has been deleted

[Sergiy Byelozyorov, 2016-07-28 13:01:36]

lgtm

https://codereview.chromium.org/2190703002/diff/100001/testing_support/auto_s...
File testing_support/auto_stub.py (right):

https://codereview.chromium.org/2190703002/diff/100001/testing_support/auto_s...
testing_support/auto_stub.py:37: for k, v in sorted(kwargs.items()))
iteritems?

https://codereview.chromium.org/2190703002/diff/100001/testing_support/tests/...
File testing_support/tests/auto_stub_test.py (right):

https://codereview.chromium.org/2190703002/diff/100001/testing_support/tests/...
testing_support/tests/auto_stub_test.py:30: auto_stub.format_call('method1', 1,
b=3, c=4, a=2),
nice that you also randomize the order here

[tandrii(chromium), 2016-07-28 13:03:35]

Description was changed from

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org
==========

to

==========
Require sanity: sort kwargs expectations. NOT OPTIONAL.

R=sergiyb@chromium.org

Committed:
https://chromium.googlesource.com/infra/testing/testing_support/+/6c5c35640c9...
==========

[tandrii(chromium), 2016-07-28 13:03:36]

Committed patchset #4 (id:120001) manually as
6c5c35640c9ea1dbc5e1976bc3a44b543339388f (presubmit successful).

[tandrii(chromium), 2016-07-28 13:04:07]

https://codereview.chromium.org/2190703002/diff/100001/testing_support/auto_s...
File testing_support/auto_stub.py (right):

https://codereview.chromium.org/2190703002/diff/100001/testing_support/auto_s...
testing_support/auto_stub.py:37: for k, v in sorted(kwargs.items()))
On 2016/07/28 13:01:36, Sergiy Byelozyorov wrote:
> iteritems?

Done.