Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7411)

Unified Diff: chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h

Issue 2190653003: [Md Feedback] Add initial data population for dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per afakhry@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h
diff --git a/chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h b/chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..57691ae5f9d300d7bf4c82cb6a274d9b653fc360
--- /dev/null
+++ b/chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_WEBUI_MESSAGE_HANDLER_H_
+#define CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_WEBUI_MESSAGE_HANDLER_H_
+
+#include "base/macros.h"
+#include "content/public/browser/web_ui_message_handler.h"
+
+namespace content {
+class WebUI;
+}
afakhry 2016/08/11 23:31:31 We don't need this forward declare here. Please re
apacible 2016/08/12 01:46:42 Done.
+
+class MdFeedbackUI;
+
+// The handler for Javascript messages related to the feedback dialog.
+class MdFeedbackWebUIMessageHandler : public content::WebUIMessageHandler {
+ public:
+ explicit MdFeedbackWebUIMessageHandler(MdFeedbackUI* md_feedback_ui);
+ ~MdFeedbackWebUIMessageHandler() override;
+
+ private:
+ // WebUIMessageHandler implementation.
afakhry 2016/08/11 23:31:31 Recently this parent-class override comment has be
apacible 2016/08/12 01:46:42 Done.
+ void RegisterMessages() override;
+
+ // Handlers for JavaScript messages.
afakhry 2016/08/11 23:31:32 Hmmm, I'd rather this comment tells us what OnRequ
apacible 2016/08/12 01:46:42 Done.
+ void OnRequestData(const base::ListValue* args);
+
+ MdFeedbackUI* md_feedback_ui_;
afakhry 2016/08/11 23:31:32 Nit [optional]: MdFeedbackUI* md_feedback_ui_; //
apacible 2016/08/12 01:46:42 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(MdFeedbackWebUIMessageHandler);
+};
+
+#endif // CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_WEBUI_MESSAGE_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698