Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2721)

Unified Diff: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc

Issue 2190653003: [Md Feedback] Add initial data population for dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
diff --git a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
index 67a56bea726fd6162eaf8cdd12a86bbf1ac57bb8..f8c7f5963c24258f3400f9067e28211323a85d40 100644
--- a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
+++ b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/webui/md_feedback/md_feedback_ui.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/browser/browser_context.h"
@@ -104,6 +105,10 @@ content::WebUIDataSource* CreateMdFeedbackUIHTMLSource(Profile* profile) {
html_source->AddLocalizedString("sendSystemInfoLabel",
IDS_MD_FEEDBACK_SEND_SYSTEM_INFO_LABEL);
+ // File resources.
+ html_source->AddResourcePath("feedback.js",
+ IDR_MD_FEEDBACK_FEEDBACK_JS);
+
// Polymer resources.
html_source->AddResourcePath("feedback_container.html",
IDR_MD_FEEDBACK_FEEDBACK_CONTAINER_HTML);
@@ -118,12 +123,16 @@ content::WebUIDataSource* CreateMdFeedbackUIHTMLSource(Profile* profile) {
} // namespace
MdFeedbackUI::MdFeedbackUI(content::WebUI* web_ui)
- : content::WebUIController(web_ui) {
+ : content::WebUIController(web_ui),
+ handler_(new MdFeedbackWebUIMessageHandler(this)) {
afakhry 2016/08/03 23:56:01 You don't need that internal reference |handler_|
apacible 2016/08/11 18:50:33 Done.
// Set up the chrome://feedback data html_source.
Profile* profile = Profile::FromWebUI(web_ui);
content::WebUIDataSource* html_source =
CreateMdFeedbackUIHTMLSource(profile);
content::WebUIDataSource::Add(profile, html_source);
+
+ // Ownership of |handler_| is transferred to |web_ui|.
+ web_ui->AddMessageHandler(handler_);
}
MdFeedbackUI::~MdFeedbackUI() {}

Powered by Google App Engine
This is Rietveld 408576698