[Md Feedback] Add initial data population for dialog.

chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/md_feedback/md_feedback_webui_message_handler.h"
+
+#include "base/bind.h"
+#include "base/values.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/webui/md_feedback/md_feedback_ui.h"
+
+namespace {
+
+// Message names.
+const char kRequestData[] = "requestData";

[afakhry, 2016/08/11 23:31:31]

constexpr

[apacible, 2016/08/12 01:46:42]

Done.

+
+// JS function names.
+const char kSetData[] = "feedback.ui.setData";

[afakhry, 2016/08/11 23:31:31]

constexpr

[apacible, 2016/08/12 01:46:42]

Done.

+
+GURL GetTargetTabUrl(int session_id, int index) {
+  Browser* browser = chrome::FindBrowserWithID(session_id);
+  // Sanity checks.
+  if (!browser || index >= browser->tab_strip_model()->count())
+    return GURL();
+
+  if (index >= 0) {
+    content::WebContents* target_tab =
+        browser->tab_strip_model()->GetWebContentsAt(index);
+    if (target_tab)
+      return target_tab->GetURL();
+  }
+
+  return GURL();
+}

[afakhry, 2016/08/11 23:31:31]

I totally understand your intent and agree with you that this function should be
local here. But that would be valid once we have your MD feedback dialog up and
running and we remove the other one. :)

Since this is shared code, we can't land duplicate code. So how about this:

create something like feedback_dialog_utils.h/cc where you add
GetFeedbackTargetTabUrl() and GetFeedbackProfile(). Have your code here as well
as the one in show_feedback_page.cc use these two new functions and then remove
all duplication. How does that sound?

[apacible, 2016/09/10 07:47:00]

Done. Also pulled out GetFeedbackProfile(), but since we don't have a Browser
here to get the profile in the same way as show_feedback_page.cc, I used the
Profile tied with what's used to create MdFeedbackUI.

+
+}  // namespace
+
+MdFeedbackWebUIMessageHandler::MdFeedbackWebUIMessageHandler(
+    MdFeedbackUI* md_feedback_ui)
+  : md_feedback_ui_(md_feedback_ui) {
+  DCHECK(md_feedback_ui_);
+}
+
+MdFeedbackWebUIMessageHandler::~MdFeedbackWebUIMessageHandler() {
+}
+
+void MdFeedbackWebUIMessageHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback(
+      kRequestData,
+      base::Bind(&MdFeedbackWebUIMessageHandler::OnRequestData,
+                 base::Unretained(this)));
+}
+
+void MdFeedbackWebUIMessageHandler::OnRequestData(const base::ListValue* args) {
+  DVLOG(1) << "OnRequestData";
+  base::DictionaryValue data;
+
+  // Do not launch feedback on an OTR profile.
+  // TODO(apacible): Handle multiple profiles on CrOS.
+  Profile* profile =
+      ProfileManager::GetLastUsedProfileAllowedByPolicy();
+  profile = profile->GetOriginalProfile();
+  DCHECK(profile);
+  data.SetString("email", profile->GetProfileUserName());

[afakhry, 2016/08/11 23:31:31]

For the email, in the current feedback app we use the SigninManagerFactory to
get its value. Please see:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/feedback_p...

I think we should do the same thing here.

[apacible, 2016/09/10 07:47:00]

Done.

+
+  GURL page_url = GURL();
+  Browser* browser = chrome::FindBrowserWithProfile(profile);
+  if (browser) {
+    page_url = GetTargetTabUrl(browser->session_id().id(),
+                               browser->tab_strip_model()->active_index());
+  }
+
+  data.SetString("url", page_url.spec());
+
+  web_ui()->CallJavascriptFunctionUnsafe(kSetData, data);
+}