Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2190633002: Add flag to launch two displays for mus+ash. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, Alex Z.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to launch two displays for mus+ash. Add --multi-display flag to launch two displays when running mus+ash under Ozone X11. This creates two 800x800 displays that are side by side. The displays should appear fine but event targeting (and other things) are broken. This patch is intended to allow testing and fix bugs related to multiple displays. Ideally, mash should use the same flags to setup multiple displays for testing that ash contains right now. The code to parse the flag contents is being refactored out of ash but cannot be used in //services/ui yet. This patch also changes ViewportMetrics to store display bound instead of just display size. BUG=611475 Committed: https://crrev.com/bb8c2fedfb2bc06d3fb3666147e4d16781d9ebc5 Cr-Commit-Position: refs/heads/master@{#408183}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M services/ui/display/platform_screen_impl_ozone.cc View 1 3 chunks +14 lines, -3 lines 0 comments Download
M services/ui/ws/display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/frame_generator_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/platform_display.h View 2 chunks +4 lines, -1 line 0 comments Download
M services/ui/ws/platform_display.cc View 3 chunks +16 lines, -11 lines 0 comments Download
M services/ui/ws/test_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kylechar
4 years, 4 months ago (2016-07-27 14:37:23 UTC) #2
kylechar
Change to sky@chromium.org.
4 years, 4 months ago (2016-07-27 14:44:00 UTC) #4
sky
LGTM We may want a format similar to that uysed by DisplayManagerTestApi, but this is ...
4 years, 4 months ago (2016-07-27 15:36:43 UTC) #5
kylechar
Thanks! https://codereview.chromium.org/2190633002/diff/1/services/ui/display/platform_screen_impl_ozone.cc File services/ui/display/platform_screen_impl_ozone.cc (right): https://codereview.chromium.org/2190633002/diff/1/services/ui/display/platform_screen_impl_ozone.cc#newcode80 services/ui/display/platform_screen_impl_ozone.cc:80: if (displays.size() > 1) On 2016/07/27 15:36:43, sky ...
4 years, 4 months ago (2016-07-27 17:25:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190633002/20001
4 years, 4 months ago (2016-07-27 17:27:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 18:15:14 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:16:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb8c2fedfb2bc06d3fb3666147e4d16781d9ebc5
Cr-Commit-Position: refs/heads/master@{#408183}

Powered by Google App Engine
This is Rietveld 408576698