Add bookmark provider for content suggestions

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
@@ skipping 89 matching lines @@
 #endif
 
 #if defined(ENABLE_SUPERVISED_USERS)
 #include "chrome/browser/supervised_user/child_accounts/child_account_service.h"
 #include "chrome/browser/supervised_user/child_accounts/child_account_service_factory.h"
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
 #endif
 
 #if defined(OS_ANDROID)
+#include "chrome/browser/android/ntp/bookmark_suggestions_provider_factory.h"
 #include "chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/browser_process_platform_part_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/cryptohome_client.h"
@@ skipping 1100 matching lines @@
 
   // Service is responsible for migration of the legacy password manager
   // preference which controls behaviour of the Chrome to the new preference
   // which controls password management behaviour on Chrome and Android. After
   // migration will be performed for all users it's planned to remove the
   // migration code, rough time estimates are Q1 2016.
   PasswordManagerSettingMigratorServiceFactory::GetForProfile(profile)
       ->InitializeMigration(ProfileSyncServiceFactory::GetForProfile(profile));
 
 #if defined(OS_ANDROID)
-  // Service is responsible for fetching content snippets for the NTP.
+  // TODO(pke): Remove all these initializer lines.
+  // Do not add any more suggestion provider initializers. This is not the place
+  // where every single profile-keyed service should be initialized. By default,
+  // profile-keyed services are lazily created when needed. If there is
+  // something that needs to happen at startup (like scheduling the fetching
+  // task), the factory can declare that it wants to be created with the
+  // profile. If we want to only add some providers under certain conditions, we
+  // can move the provider registration code e.g. to the
+  // ContentSuggestionsFactory, which would have the advantage that it would
+  // centralize it. Service is responsible for fetching content snippets for the
+  // NTP.
   ContentSuggestionsServiceFactory::GetForProfile(profile);
   NTPSnippetsServiceFactory::GetForProfile(profile);
   OfflinePageSuggestionsProviderFactory::GetForProfile(profile);
+  BookmarkSuggestionsProviderFactory::GetForProfile(profile);
 #endif
 }
 
 void ProfileManager::DoFinalInitLogging(Profile* profile) {
   TRACE_EVENT0("browser", "ProfileManager::DoFinalInitLogging");
   // Count number of extensions in this profile.
   int enabled_app_count = -1;
 #if defined(ENABLE_EXTENSIONS)
   enabled_app_count = GetEnabledAppCount(profile);
 #endif
@@ skipping 387 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }