Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2190563002:
[heap] ObjectStats: Fixes for recording HashTable overhead (Closed)
|
Created:
4 years, 4 months ago by Michael Lippautz Modified:
4 years, 4 months ago Reviewers:
Hannes Payer (out of office) CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] ObjectStats: Fixes for recording HashTable overhead
- Overhead for HashTable was not accounted in bytes
- Name table in typefeedback metadata changed
BUG=chromium:631094
R=hpayer@chromium.org
Committed: https://crrev.com/53dde335b9f11b409b24cfdcdc24164388747735
Cr-Commit-Position: refs/heads/master@{#38098}
Patch Set 1 #Patch Set 2 : Fixes #Messages
Total messages: 19 (14 generated)
Description was changed from ========== [heap] ObjectStats: Fix accounting of HashTable overhead BUG= ========== to ========== [heap] ObjectStats: Fix accounting of HashTable overhead BUG=chromium:631094 R=hpayer@chromium.org ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] ObjectStats: Fix accounting of HashTable overhead BUG=chromium:631094 R=hpayer@chromium.org ========== to ========== [heap] ObjectStats: Fixes recording - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] ObjectStats: Fixes recording - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ========== to ========== [heap] ObjectStats: Fixes for recording hashtable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ==========
Description was changed from ========== [heap] ObjectStats: Fixes for recording hashtable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ========== to ========== [heap] ObjectStats: Fixes for recording HashTable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] ObjectStats: Fixes for recording HashTable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ========== to ========== [heap] ObjectStats: Fixes for recording HashTable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [heap] ObjectStats: Fixes for recording HashTable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org ========== to ========== [heap] ObjectStats: Fixes for recording HashTable overhead - Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org Committed: https://crrev.com/53dde335b9f11b409b24cfdcdc24164388747735 Cr-Commit-Position: refs/heads/master@{#38098} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/53dde335b9f11b409b24cfdcdc24164388747735 Cr-Commit-Position: refs/heads/master@{#38098} |
