Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2190543003: [swarming] Remove hard-coded shared library configs (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Remove hard-coded shared library configs The isolate_driver automatically adds referenced shared libraries. They don't need to be listed explicitly. The hard-coded location blocks the GN transition as the library location is different in GYP and GN. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/784a636f3e5d940bc4dea7486b3ae358a5f47a52 Cr-Commit-Position: refs/heads/master@{#38113}

Patch Set 1 #

Patch Set 2 : Remove unused config var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M gni/isolate.gni View 1 2 chunks +0 lines, -7 lines 0 comments Download
M gypfiles/isolate.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/base.isolate View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-07-27 14:41:14 UTC) #5
Michael Achenbach
Tested locally: GYP_DEFINES="asan=1 test_isolation_mode=prepare use_goma=1" gclient runhooks ninja -C out/Release -j1000 d8_run isolate.py batcharchive -I ...
4 years, 4 months ago (2016-07-27 14:53:16 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-28 07:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190543003/20001
4 years, 4 months ago (2016-07-28 07:16:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 07:17:24 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 07:18:25 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/784a636f3e5d940bc4dea7486b3ae358a5f47a52
Cr-Commit-Position: refs/heads/master@{#38113}

Powered by Google App Engine
This is Rietveld 408576698