Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2190543002: [turbofan] Also eliminate branches during load elimination. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also eliminate branches during load elimination. Also run the BranchElimination (plus CommonOperatorReducer and the DeadCodeElimination) during the load elimination phase, so we can elminate some Phi nodes early on that would otherwise confuse the truncation analysis and/or representation selection, i.e. if there's a branch that is never taken, that would yield undefined, we'd have to choose tagged representation for the Phi, even if the always taken branch yields an integer. R=epertoso@chromium.org BUG=v8:4930, v8:5141 Committed: https://crrev.com/14e2bcda857ba7d2307f0514cccb76b496721369 Cr-Commit-Position: refs/heads/master@{#38088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-27 09:02:21 UTC) #1
Benedikt Meurer
Hey Enrico, Here's a simple improvement for the pipeline. Please take a look. Thanks, Benedikt
4 years, 4 months ago (2016-07-27 09:03:26 UTC) #4
epertoso
lgtm Nice.
4 years, 4 months ago (2016-07-27 09:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190543002/1
4 years, 4 months ago (2016-07-27 09:05:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 09:25:09 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 09:29:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14e2bcda857ba7d2307f0514cccb76b496721369
Cr-Commit-Position: refs/heads/master@{#38088}

Powered by Google App Engine
This is Rietveld 408576698