chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc - Issue 2190533002: Adds a WebRTC browser_test with opus dtx enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

Issue 2190533002: Adds a WebRTC browser_test with opus dtx enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

index 0c946cec013f9dd688a9f748e211d334c354f706..c869278f71cb4cd1afb050bea85e53798a9e7074 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

@@ -161,7 +161,9 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest, TestStartStopWebRtcEventLogging) {

SetupPeerconnectionWithLocalStream(left_tab);

SetupPeerconnectionWithLocalStream(right_tab);

- NegotiateCall(left_tab, right_tab, "VP8");

+ SetDefaultVideoCodec(left_tab, "VP8");

+ SetDefaultVideoCodec(right_tab, "VP8");

+ NegotiateCall(left_tab, right_tab);

StartDetectingVideo(left_tab, "remote-view");

StartDetectingVideo(right_tab, "remote-view");

@@ -251,7 +253,9 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest,