Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Unified Diff: chrome/browser/media/webrtc_browsertest.cc

Issue 2190533002: Adds a WebRTC browser_test with opus dtx enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Last comments by Minyue. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_browsertest.cc
diff --git a/chrome/browser/media/webrtc_browsertest.cc b/chrome/browser/media/webrtc_browsertest.cc
index 81e9033b46c206af256e943014eaa8a5c7391baa..cb084189166e3d55f881450dfa86c8cd978d0ad7 100644
--- a/chrome/browser/media/webrtc_browsertest.cc
+++ b/chrome/browser/media/webrtc_browsertest.cc
@@ -62,7 +62,11 @@ class WebRtcBrowserTest : public WebRtcTestBase {
SetupPeerconnectionWithLocalStream(left_tab_, offer_cert_keygen_alg);
SetupPeerconnectionWithLocalStream(right_tab_, answer_cert_keygen_alg);
- NegotiateCall(left_tab_, right_tab_, video_codec);
+ if (!video_codec.empty()) {
+ SetDefaultVideoCodec(left_tab_, video_codec);
+ SetDefaultVideoCodec(right_tab_, video_codec);
+ }
+ NegotiateCall(left_tab_, right_tab_);
DetectVideoAndHangUp();
}
@@ -84,7 +88,7 @@ class WebRtcBrowserTest : public WebRtcTestBase {
left_tab_, "gCertificateClone");
SetupPeerconnectionWithLocalStream(right_tab_, cert_keygen_alg);
- NegotiateCall(left_tab_, right_tab_, WebRtcTestBase::kUseDefaultVideoCodec);
+ NegotiateCall(left_tab_, right_tab_);
DetectVideoAndHangUp();
}

Powered by Google App Engine
This is Rietveld 408576698