Adds a WebRTC browser_test with opus dtx enabled.

chrome/browser/media/webrtc_browsertest_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/webrtc_browsertest_base.h"
 
 #include <stddef.h>
 
 #include "base/lazy_instance.h"
 #include "base/macros.h"
@@ skipping 317 matching lines @@
 }
 
 void WebRtcTestBase::SetupPeerconnectionWithCertificateWithoutLocalStream(
     content::WebContents* tab,
     const std::string& certificate) const {
   std::string javascript = base::StringPrintf(
       "preparePeerConnectionWithCertificate(%s)", certificate.c_str());
   EXPECT_EQ("ok-peerconnection-created", ExecuteJavascript(javascript, tab));
 }
 
-std::string WebRtcTestBase::CreateLocalOffer(
-      content::WebContents* from_tab,
-      std::string default_video_codec) const {
+std::string WebRtcTestBase::CreateLocalOffer(content::WebContents* from_tab,

[phoglund_chromium, 2016/07/27 09:15:05]

I'm concerned this is going to go out of control if we keep adding more
parameters. Right now every configuration parameter goes through and clutters
createLocalOffer and other functions.

I think we have two options: either 

1) wrap codec and dtx in a config struct and pass as a js object, e.g.

struct WebRtcTestConfig {
  std::string default_video_codec;
  std::string opus_dtx;  // "true" or "false"

  std::string ToJavascript() {
    return base::StringPrintf("{ default_video_codec: %s, opus_dtx = %s }", 
                              default_video_codec, opus_dtx);
  }
};

Then the js code can just read config.opus_dtx.

or 2)

Make setters and global objects in js and remove variables from createoffer and
answer, e.g.

var gOpusDtx = false;

function forceOpusDtx() {
  gOpusDtx = true;
  returnToTest('ok-forced');
}

...

if (gOpusDtx) {
  munge sdp
}

and make a setter in webrtc_browsertest_base that calls

EXPECT_EQ("ok-forced", ExecuteJavascript("forceOpusDtx()"));

Then you can just call that setter from your test function after loading the
test page but before negotiating the call. In that case we should move
video_codec as well.

I think I prefer 2), what do you think?

[Ivo-OOO until feb 6, 2016/07/27 14:12:43]

Good point, I implemented option 2.

+                                             std::string default_video_codec,
+                                             bool opus_dtx) const {
   if (default_video_codec.empty())
     default_video_codec = "null";
   else
     default_video_codec = "'" + default_video_codec + "'";
-  std::string javascript = base::StringPrintf(
-      "createLocalOffer({}, %s)", default_video_codec.c_str());
+  std::string javascript = base::StringPrintf("createLocalOffer({}, %s, %s)",
+                                              default_video_codec.c_str(),
+                                              opus_dtx ? "true" : "false");
   std::string response = ExecuteJavascript(javascript, from_tab);
   EXPECT_EQ("ok-", response.substr(0, 3)) << "Failed to create local offer: "
       << response;
 
   std::string local_offer = response.substr(3);
   return local_offer;
 }
 
-std::string WebRtcTestBase::CreateAnswer(
-    std::string local_offer,
-    content::WebContents* to_tab,
-    std::string default_video_codec) const {
+std::string WebRtcTestBase::CreateAnswer(std::string local_offer,
+                                         content::WebContents* to_tab,
+                                         std::string default_video_codec,
+                                         bool opus_dtx) const {
   std::string javascript =
-      base::StringPrintf("receiveOfferFromPeer('%s', {})", local_offer.c_str());
+      base::StringPrintf("receiveOfferFromPeer('%s', {}, %s)",
+                         local_offer.c_str(), opus_dtx ? "true" : "false");
   std::string response = ExecuteJavascript(javascript, to_tab);
   EXPECT_EQ("ok-", response.substr(0, 3))
       << "Receiving peer failed to receive offer and create answer: "
       << response;
 
   std::string answer = response.substr(3);
 
   if (!default_video_codec.empty()) {
     response = ExecuteJavascript(
         base::StringPrintf("verifyDefaultVideoCodec('%s', '%s')",
                            answer.c_str(), default_video_codec.c_str()),
         to_tab);
     EXPECT_EQ("ok-", response.substr(0, 3))
         << "Receiving peer failed to verify default codec: "
         << response;
   }
+  if (opus_dtx) {
+    response = ExecuteJavascript(
+        base::StringPrintf("verifyOpusDtxEnabled('%s')", answer.c_str()),
+        to_tab);
+    EXPECT_EQ("ok-", response.substr(0, 3))

[phoglund_chromium, 2016/07/27 09:15:05]

Just check ok-verified. In the above the response can be dynamic but you can
either get ok-verified or nothing right?

[Ivo-OOO until feb 6, 2016/07/27 14:12:43]

I moved this code to the javascript side, so this is no longer an issue.

+        << "Receiving peer failed to verify opus dtx: " << response;
+  }
 
   return answer;
 }
 
 void WebRtcTestBase::ReceiveAnswer(const std::string& answer,
                                    content::WebContents* from_tab) const {
   ASSERT_EQ(
       "ok-accepted-answer",
       ExecuteJavascript(
           base::StringPrintf("receiveAnswerFromPeer('%s')", answer.c_str()),
           from_tab));
 }
 
 void WebRtcTestBase::GatherAndSendIceCandidates(
     content::WebContents* from_tab,
     content::WebContents* to_tab) const {
   std::string ice_candidates =
       ExecuteJavascript("getAllIceCandidates()", from_tab);
 
   EXPECT_EQ("ok-received-candidates", ExecuteJavascript(
       base::StringPrintf("receiveIceCandidates('%s')", ice_candidates.c_str()),
       to_tab));
 }
 
 void WebRtcTestBase::NegotiateCall(content::WebContents* from_tab,
                                    content::WebContents* to_tab,
-                                   const std::string& video_codec) const {
-  std::string local_offer = CreateLocalOffer(from_tab, video_codec);
-  std::string answer = CreateAnswer(local_offer, to_tab, video_codec);
+                                   const std::string& video_codec,
+                                   bool opus_dtx) const {
+  std::string local_offer = CreateLocalOffer(from_tab, video_codec, opus_dtx);
+  std::string answer = CreateAnswer(local_offer, to_tab, video_codec, opus_dtx);
   ReceiveAnswer(answer, from_tab);
 
   // Send all ICE candidates (wait for gathering to finish if necessary).
   GatherAndSendIceCandidates(to_tab, from_tab);
   GatherAndSendIceCandidates(from_tab, to_tab);
 }
 
 void WebRtcTestBase::HangUp(content::WebContents* from_tab) const {
   EXPECT_EQ("ok-call-hung-up", ExecuteJavascript("hangUp()", from_tab));
 }
@@ skipping 62 matching lines @@
 }
 
 void WebRtcTestBase::GenerateAndCloneCertificate(
     content::WebContents* tab, const std::string& keygen_algorithm) const {
   std::string javascript = base::StringPrintf(
       "generateAndCloneCertificate(%s)", keygen_algorithm.c_str());
   std::string response = ExecuteJavascript(javascript, tab);
   EXPECT_EQ("ok-generated-and-cloned", response) << "Failed to generate and "
       "clone certificate: " << response;
 }