Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 219053003: Deprecate automatic generation of precompiled.js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 891a33bcf4b8e22fb38755613b631fa55ac126cf..4f280f38711ae4f79ac8eb4c056f19a92186fc2a 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -249,7 +249,6 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
List arguments,
Map<String, String> environmentOverrides) {
String normalOutput = '$tempDir/out.js';
ricow1 2014/04/01 10:37:58 just inline the string
Johnni Winther 2014/04/01 13:52:35 Done.
- String cspOutput = '$tempDir/out.precompiled.js';
return new CommandArtifact(
<Command>[
this.computeCompilationCommand(
@@ -258,11 +257,7 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
CommandBuilder.instance,
arguments,
environmentOverrides)],
- // dart2js always produce both out.js and out.precompiled.js. To avoid
- // recompiling the CSP version, we always tell the CompilationCommand
- // to track the timestamp of out.js, but select which one to run based
- // on CSP mode.
- isCsp ? cspOutput : normalOutput,
+ normalOutput,
'application/javascript');
}

Powered by Google App Engine
This is Rietveld 408576698