Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 219053003: Deprecate automatic generation of precompiled.js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show 7 import 'dart:io' show
8 Platform; 8 Platform;
9 9
10 import 'runtime_configuration.dart' show 10 import 'runtime_configuration.dart' show
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 if (isHostChecked) multiplier *= 16; 241 if (isHostChecked) multiplier *= 16;
242 return multiplier; 242 return multiplier;
243 } 243 }
244 244
245 CommandArtifact computeCompilationArtifact( 245 CommandArtifact computeCompilationArtifact(
246 String buildDir, 246 String buildDir,
247 String tempDir, 247 String tempDir,
248 CommandBuilder commandBuilder, 248 CommandBuilder commandBuilder,
249 List arguments, 249 List arguments,
250 Map<String, String> environmentOverrides) { 250 Map<String, String> environmentOverrides) {
251 String normalOutput = '$tempDir/out.js';
252 String cspOutput = '$tempDir/out.precompiled.js';
253 return new CommandArtifact( 251 return new CommandArtifact(
254 <Command>[ 252 <Command>[
255 this.computeCompilationCommand( 253 this.computeCompilationCommand(
256 normalOutput, 254 '$tempDir/out.js',
257 buildDir, 255 buildDir,
258 CommandBuilder.instance, 256 CommandBuilder.instance,
259 arguments, 257 arguments,
260 environmentOverrides)], 258 environmentOverrides)],
261 // dart2js always produce both out.js and out.precompiled.js. To avoid 259 '$tempDir/out.js',
262 // recompiling the CSP version, we always tell the CompilationCommand
263 // to track the timestamp of out.js, but select which one to run based
264 // on CSP mode.
265 isCsp ? cspOutput : normalOutput,
266 'application/javascript'); 260 'application/javascript');
267 } 261 }
268 262
269 List<String> computeRuntimeArguments( 263 List<String> computeRuntimeArguments(
270 RuntimeConfiguration runtimeConfiguration, 264 RuntimeConfiguration runtimeConfiguration,
271 String buildDir, 265 String buildDir,
272 TestInformation info, 266 TestInformation info,
273 List<String> vmOptions, 267 List<String> vmOptions,
274 List<String> sharedOptions, 268 List<String> sharedOptions,
275 List<String> originalArguments, 269 List<String> originalArguments,
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 bool isDebug, 383 bool isDebug,
390 bool isChecked, 384 bool isChecked,
391 bool isHostChecked, 385 bool isHostChecked,
392 bool useSdk}) 386 bool useSdk})
393 : super( 387 : super(
394 'dart2analyzer', isDebug: isDebug, isChecked: isChecked, 388 'dart2analyzer', isDebug: isDebug, isChecked: isChecked,
395 isHostChecked: isHostChecked, useSdk: useSdk); 389 isHostChecked: isHostChecked, useSdk: useSdk);
396 390
397 String computeCompilerPath(String buildDir) => 'editor/tools/analyzer'; 391 String computeCompilerPath(String buildDir) => 'editor/tools/analyzer';
398 } 392 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698