Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2190523003: Fixing regression in putImageData blink perf test (Closed)

Created:
4 years, 4 months ago by Justin Novosad
Modified:
4 years, 4 months ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing regression in putImageData blink perf test Creating the image data object by using createImageData instead of getImageData to avoid state changes that interfere with the benchmark's execution. Also doing a drive-by code simplification BUG=630670 Committed: https://crrev.com/c3a213e577d12c648fce456d2e0098fe36194abd Cr-Commit-Position: refs/heads/master@{#409263}

Patch Set 1 #

Total comments: 1

Patch Set 2 : cp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M third_party/WebKit/PerformanceTests/Canvas/putImageData.html View 1 1 chunk +2 lines, -20 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Justin Novosad
PTAL
4 years, 4 months ago (2016-07-27 20:25:58 UTC) #4
xidachen
https://codereview.chromium.org/2190523003/diff/1/third_party/WebKit/PerformanceTests/Canvas/putImageData.html File third_party/WebKit/PerformanceTests/Canvas/putImageData.html (right): https://codereview.chromium.org/2190523003/diff/1/third_party/WebKit/PerformanceTests/Canvas/putImageData.html#newcode10 third_party/WebKit/PerformanceTests/Canvas/putImageData.html:10: imageData = ctx2D.createImageData(canvas2D.width, canvas2D.height); If my understanding is correct, ...
4 years, 4 months ago (2016-07-28 01:17:59 UTC) #7
Justin Novosad
Done
4 years, 4 months ago (2016-08-02 17:54:39 UTC) #8
xidachen
lgtm
4 years, 4 months ago (2016-08-02 17:55:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190523003/20001
4 years, 4 months ago (2016-08-02 18:29:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 19:11:35 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:12:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3a213e577d12c648fce456d2e0098fe36194abd
Cr-Commit-Position: refs/heads/master@{#409263}

Powered by Google App Engine
This is Rietveld 408576698