DescriptionRevert of Add scroll perf test for protocol in chromoting (patchset #3 id:60001 of https://codereview.chromium.org/2182833002/ )
Reason for revert:
Causes build errors
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/1109
[4615/7755] LINK_EMBED remoting_perftests.exe
FAILED: remoting_perftests.exe remoting_perftests.exe.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True remoting_perftests.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:remoting_perftests.exe @remoting_perftests.exe.rsp" 1 mt.exe rc.exe "obj\remoting\remoting_perftests.remoting_perftests.exe.intermediate.manifest" obj\remoting\remoting_perftests.remoting_perftests.exe.generated.manifest ..\..\build\win\compatibility.manifest
remoting_perftests.protocol_perftest.obj : error LNK2019: unresolved external symbol "public: __thiscall remoting::test::ScrollFrameGenerator::ScrollFrameGenerator(void)" (??0ScrollFrameGenerator@test@remoting@@QAE@XZ) referenced in function "protected: void __thiscall remoting::ProtocolPerfTest::MeasureScrollPerformance(bool)" (?MeasureScrollPerformance@ProtocolPerfTest@remoting@@IAEX_N@Z)
remoting_perftests.protocol_perftest.obj : error LNK2019: unresolved external symbol "public: class std::unique_ptr<class webrtc::DesktopFrame,struct std::default_delete<class webrtc::DesktopFrame> > __thiscall remoting::test::ScrollFrameGenerator::GenerateFrame(class webrtc::SharedMemoryFactory *)" (?GenerateFrame@ScrollFrameGenerator@test@remoting@@QAE?AV?$unique_ptr@VDesktopFrame@webrtc@@U?$default_delete@VDesktopFrame@webrtc@@@std@@@std@@PAVSharedMemoryFactory@webrtc@@@Z) referenced in function "protected: void __thiscall remoting::ProtocolPerfTest::MeasureScrollPerformance(bool)" (?MeasureScrollPerformance@ProtocolPerfTest@remoting@@IAEX_N@Z)
remoting_perftests.protocol_perftest.obj : error LNK2019: unresolved external symbol "public: class base::TimeDelta __thiscall remoting::test::ScrollFrameGenerator::GetFrameLatency(class webrtc::DesktopFrame const &)" (?GetFrameLatency@ScrollFrameGenerator@test@remoting@@QAE?AVTimeDelta@base@@ABVDesktopFrame@webrtc@@@Z) referenced in function "protected: void __thiscall remoting::ProtocolPerfTest::MeasureScrollPerformance(bool)" (?MeasureScrollPerformance@ProtocolPerfTest@remoting@@IAEX_N@Z)
remoting_perftests.protocol_perftest.obj : error LNK2019: unresolved external symbol "private: __thiscall remoting::test::ScrollFrameGenerator::~ScrollFrameGenerator(void)" (??1ScrollFrameGenerator@test@remoting@@AAE@XZ) referenced in function "private: void * __thiscall remoting::test::ScrollFrameGenerator::`scalar deleting destructor'(unsigned int)" (??_GScrollFrameGenerator@test@remoting@@AAEPAXI@Z)
remoting_perftests.exe : fatal error LNK1120: 4 unresolved externals
Original issue's description:
> Add scroll perf test for protocol in chromoting
>
> The new test simulates frame scroll and measures frame-rate and average
> latency.
>
> Some results from the new test:
>
> LimitedBandwidth/0 (100Mbps):
> ICE: FPS: 29.7853, Average latency: 49.7429
> Webrtc: FPS: 10.4109, Average latency: 71.0577
>
> LimitedBandwidth/1 (8Mbps):
> ICE: FPS: 5.24054, Average latency: 734.131
> Webrtc: FPS: 11.1471, Average latency: 116.915
>
> Committed: https://crrev.com/8bc24e1f6de205377e3dbb814aeecaf8fe05a867
> Cr-Commit-Position: refs/heads/master@{#407957}
TBR=isheriff@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/20acfad6efb0b07449de4f0869e24052943a44b1
Cr-Commit-Position: refs/heads/master@{#407990}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|