Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: components/error_page/common/localized_error.cc

Issue 2190463008: Add an error page for HTTP 404 error pages without bodies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch runtime test to title1.html Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/form.html ('k') | extensions/browser/api/runtime/runtime_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/localized_error.cc
diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc
index 56ac72ad7fb344c5d8594eca9ae08ceca801fdef..fd4be4a3072f67510fcb5af340b5268a6e96ac53 100644
--- a/components/error_page/common/localized_error.cc
+++ b/components/error_page/common/localized_error.cc
@@ -370,56 +370,50 @@ const LocalizedErrorMap repost_error = {
};
const LocalizedErrorMap http_error_options[] = {
- {403,
- IDS_ERRORPAGES_TITLE_ACCESS_DENIED,
- IDS_ERRORPAGES_HEADING_ACCESS_DENIED,
- IDS_ERRORPAGES_SUMMARY_FORBIDDEN,
- SUGGEST_NONE,
- SHOW_BUTTON_RELOAD,
- },
- {410,
- IDS_ERRORPAGES_TITLE_NOT_FOUND,
- IDS_ERRORPAGES_HEADING_NOT_FOUND,
- IDS_ERRORPAGES_SUMMARY_GONE,
- SUGGEST_NONE,
- SHOW_NO_BUTTONS,
- },
-
- {500,
- IDS_ERRORPAGES_TITLE_LOAD_FAILED,
- IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
- IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST,
- SUGGEST_NONE,
- SHOW_BUTTON_RELOAD,
- },
- {501,
- IDS_ERRORPAGES_TITLE_LOAD_FAILED,
- IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
- IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST,
- SUGGEST_NONE,
- SHOW_NO_BUTTONS,
- },
- {502,
- IDS_ERRORPAGES_TITLE_LOAD_FAILED,
- IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
- IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST,
- SUGGEST_NONE,
- SHOW_BUTTON_RELOAD,
- },
- {503,
- IDS_ERRORPAGES_TITLE_LOAD_FAILED,
- IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
- IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST,
- SUGGEST_NONE,
- SHOW_BUTTON_RELOAD,
- },
- {504,
- IDS_ERRORPAGES_TITLE_LOAD_FAILED,
- IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
- IDS_ERRORPAGES_SUMMARY_GATEWAY_TIMEOUT,
- SUGGEST_NONE,
- SHOW_BUTTON_RELOAD,
- },
+ {
+ 403, IDS_ERRORPAGES_TITLE_ACCESS_DENIED,
+ IDS_ERRORPAGES_HEADING_ACCESS_DENIED, IDS_ERRORPAGES_SUMMARY_FORBIDDEN,
+ SUGGEST_NONE, SHOW_BUTTON_RELOAD,
+ },
+ {
+ 404, IDS_ERRORPAGES_TITLE_NOT_FOUND, IDS_ERRORPAGES_HEADING_NOT_FOUND,
+ IDS_ERRORPAGES_SUMMARY_NOT_FOUND, SUGGEST_NONE, SHOW_BUTTON_RELOAD,
+ },
+ {
+ 410, IDS_ERRORPAGES_TITLE_NOT_FOUND, IDS_ERRORPAGES_HEADING_NOT_FOUND,
+ IDS_ERRORPAGES_SUMMARY_GONE, SUGGEST_NONE, SHOW_NO_BUTTONS,
+ },
+
+ {
+ 500, IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
+ IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST, SUGGEST_NONE,
+ SHOW_BUTTON_RELOAD,
+ },
+ {
+ 501, IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
+ IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST, SUGGEST_NONE,
+ SHOW_NO_BUTTONS,
+ },
+ {
+ 502, IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
+ IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST, SUGGEST_NONE,
+ SHOW_BUTTON_RELOAD,
+ },
+ {
+ 503, IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
+ IDS_ERRORPAGES_SUMMARY_WEBSITE_CANNOT_HANDLE_REQUEST, SUGGEST_NONE,
+ SHOW_BUTTON_RELOAD,
+ },
+ {
+ 504, IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_PAGE_NOT_WORKING,
+ IDS_ERRORPAGES_SUMMARY_GATEWAY_TIMEOUT, SUGGEST_NONE,
+ SHOW_BUTTON_RELOAD,
+ },
};
const LocalizedErrorMap dns_probe_error_options[] = {
« no previous file with comments | « chrome/test/data/form.html ('k') | extensions/browser/api/runtime/runtime_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698