Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3179)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Issue 2190463008: Add an error page for HTTP 404 error pages without bodies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch runtime test to title1.html Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
index 1a4cb85299b810d8f9662c2882035bc24dac8541..4e9e163b3cb220f90ec38e64b588229a8ae61440 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
@@ -346,7 +346,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, MixedContent) {
ASSERT_TRUE(https_server_.Start());
SetUpMockCertVerifierForHttpsServer(0, net::OK);
host_resolver()->AddRule("example.test",
- https_server_.GetURL("/").host());
+ https_server_.GetURL("/title1.html").host());
net::HostPortPair replacement_pair = embedded_test_server()->host_port_pair();
replacement_pair.set_host("example.test");
@@ -415,12 +415,13 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, MixedContent) {
// Navigate to an HTTPS page that runs mixed content in an iframe.
net::HostPortPair host_port_pair =
- net::HostPortPair::FromURL(https_server_.GetURL("/"));
+ net::HostPortPair::FromURL(https_server_.GetURL("/title1.html"));
host_port_pair.set_host("different-host.test");
host_resolver()->AddRule("different-host.test",
- https_server_.GetURL("/").host());
- host_resolver()->AddRule("different-http-host.test",
- embedded_test_server()->GetURL("/").host());
+ https_server_.GetURL("/title1.html").host());
+ host_resolver()->AddRule(
+ "different-http-host.test",
+ embedded_test_server()->GetURL("/title1.html").host());
GetFilePathWithHostAndPortReplacement(
"/ssl/page_runs_insecure_content_in_iframe.html", host_port_pair,
&replacement_path);
@@ -446,7 +447,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest,
net::OK);
host_resolver()->AddRule("example.test",
- https_server_.GetURL("/").host());
+ https_server_.GetURL("/title1.html").host());
net::HostPortPair replacement_pair = embedded_test_server()->host_port_pair();
replacement_pair.set_host("example.test");
@@ -528,10 +529,10 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest,
// iframe, with strict mixed content blocking.
std::string replacement_path;
net::HostPortPair host_port_pair =
- net::HostPortPair::FromURL(https_server_.GetURL("/"));
+ net::HostPortPair::FromURL(https_server_.GetURL("/title1.html"));
host_port_pair.set_host("different-host.test");
host_resolver()->AddRule("different-host.test",
- https_server_.GetURL("/").host());
+ https_server_.GetURL("/title1.html").host());
GetFilePathWithHostAndPortReplacement(
"/ssl/page_runs_insecure_content_in_iframe_with_strict_blocking.html",
host_port_pair, &replacement_path);
@@ -709,7 +710,7 @@ class SecurityStateModelLoadingTest
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
base::Bind(&InstallLoadingInterceptor,
- embedded_test_server()->GetURL("/").host()));
+ embedded_test_server()->GetURL("/title1.html").host()));
}
DISALLOW_COPY_AND_ASSIGN(SecurityStateModelLoadingTest);
@@ -732,9 +733,9 @@ IN_PROC_BROWSER_TEST_F(SecurityStateModelLoadingTest, NavigationStateChanges) {
// Navigate to a page that doesn't finish loading. Test that the
// security state is neutral while the page is loading.
- browser()->OpenURL(content::OpenURLParams(embedded_test_server()->GetURL("/"),
- content::Referrer(), CURRENT_TAB,
- ui::PAGE_TRANSITION_TYPED, false));
+ browser()->OpenURL(content::OpenURLParams(
+ embedded_test_server()->GetURL("/title1.html"), content::Referrer(),
+ CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
CheckSecurityInfoForNonSecure(
browser()->tab_strip_model()->GetActiveWebContents());
}
@@ -754,7 +755,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, AddedTab) {
content::NavigationController& controller = new_contents->GetController();
ChromeSecurityStateModelClient::CreateForWebContents(new_contents);
CheckSecurityInfoForNonSecure(new_contents);
- controller.LoadURL(https_server_.GetURL("/"), content::Referrer(),
+ controller.LoadURL(https_server_.GetURL("/title1.html"), content::Referrer(),
ui::PAGE_TRANSITION_TYPED, std::string());
EXPECT_TRUE(content::WaitForLoadStop(new_contents));
CheckSecurityInfoForSecure(new_contents, SecurityStateModel::SECURE,
@@ -788,7 +789,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest, SecurityStyleChangedObserver) {
SecurityStyleTestObserver observer(web_contents);
// Visit an HTTP url.
- GURL http_url(embedded_test_server()->GetURL("/"));
+ GURL http_url(embedded_test_server()->GetURL("/title1.html"));
ui_test_utils::NavigateToURL(browser(), http_url);
EXPECT_EQ(content::SECURITY_STYLE_UNAUTHENTICATED,
observer.latest_security_style());
@@ -830,7 +831,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest, SecurityStyleChangedObserver) {
mixed_content_explanation.ran_insecure_content_style);
// Visit a broken HTTPS url.
- GURL expired_url(https_test_server_expired.GetURL(std::string("/")));
+ GURL expired_url(https_test_server_expired.GetURL("/title1.html"));
ui_test_utils::NavigateToURL(browser(), expired_url);
// An interstitial should show, and an event for the lock icon on the
@@ -848,7 +849,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest, SecurityStyleChangedObserver) {
// Before clicking through, navigate to a different page, and then go
// back to the interstitial.
- GURL valid_https_url(https_server_.GetURL(std::string("/")));
+ GURL valid_https_url(https_server_.GetURL("/title1.html"));
ui_test_utils::NavigateToURL(browser(), valid_https_url);
EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATED,
observer.latest_security_style());
@@ -914,7 +915,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest,
SecurityStyleTestObserver observer(web_contents);
// Visit a valid HTTPS url.
- GURL valid_https_url(https_server_.GetURL(std::string("/")));
+ GURL valid_https_url(https_server_.GetURL("/title1.html"));
ui_test_utils::NavigateToURL(browser(), valid_https_url);
EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATED,
observer.latest_security_style());
@@ -931,7 +932,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest,
// Navigate to a bad HTTPS page on a different host, and then click
// Back to verify that the previous good security style is seen again.
- GURL expired_https_url(https_test_server_expired.GetURL(std::string("/")));
+ GURL expired_https_url(https_test_server_expired.GetURL("/title1.html"));
host_resolver()->AddRule("www.example_broken.test", "127.0.0.1");
GURL::Replacements replace_host;
replace_host.SetHostStr("www.example_broken.test");
« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698