Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3984)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 2190463008: Add an error page for HTTP 404 error pages without bodies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch runtime test to title1.html Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_browsertest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
index 0598ea86c877d158c7631e93d25ab426d4889cc6..43664e4d6d39a44b0715c407e44148e084777d9e 100644
--- a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
@@ -55,11 +55,10 @@ class ActivityLogPrerenderTest : public ExtensionApiTest {
ASSERT_EQ("[\"/google_cs.js\"]",
ActivityLogPolicy::Util::Serialize(last->args()));
ASSERT_EQ(
- base::StringPrintf("http://www.google.com.bo:%u/test.html", port),
+ base::StringPrintf("http://www.google.com.bo:%u/title1.html", port),
last->SerializePageUrl());
- ASSERT_EQ(
- base::StringPrintf("www.google.com.bo:%u/test.html", port),
- last->page_title());
+ ASSERT_EQ(base::StringPrintf("www.google.com.bo:%u/title1.html", port),
+ last->page_title());
ASSERT_EQ("{\"prerender\":true}",
ActivityLogPolicy::Util::Serialize(last->other()));
ASSERT_EQ("", last->api_name());
@@ -102,9 +101,7 @@ IN_PROC_BROWSER_TEST_F(ActivityLogPrerenderTest, TestScriptInjected) {
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
- GURL url(base::StringPrintf(
- "http://www.google.com.bo:%u/test.html",
- port));
+ GURL url(base::StringPrintf("http://www.google.com.bo:%u/title1.html", port));
const gfx::Size kSize(640, 480);
std::unique_ptr<prerender::PrerenderHandle> prerender_handle(
« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698