chrome/browser/ui/browser_browsertest.cc - Issue 2190463008: Add an error page for HTTP 404 error pages without bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 2190463008: Add an error page for HTTP 404 error pages without bodies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moar... fixes... Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/test/data/errorpage/empty404.html » ('j') | components/error_page/common/localized_error.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index 2f3fd698d75b96c44b2699a6b7d9cdcd72fb50ad..17318f64aa84ea2cf2771179a07edacd8f05a6f0 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -994,7 +994,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, NullOpenerRedirectForksProcess) {

https_test_server.ServeFilesFromSourceDirectory(base::FilePath(kDocRoot));

ASSERT_TRUE(https_test_server.Start());

GURL http_url(embedded_test_server()->GetURL("/title1.html"));

- GURL https_url(https_test_server.GetURL(std::string("/")));

+ GURL https_url(https_test_server.GetURL("/title2.html"));

// Start with an http URL.

ui_test_utils::NavigateToURL(browser(), http_url);

« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/test/data/errorpage/empty404.html » ('j') | components/error_page/common/localized_error.cc » ('J')