Add an error page for HTTP 404 error pages without bodies.

chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <list>
 #include <set>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 32 matching lines @@
 #include "content/public/common/context_menu_params.h"
 #include "content/public/common/resource_type.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/switches.h"
 #include "extensions/test/result_catcher.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "net/test/embedded_test_server/http_request.h"
+#include "net/test/embedded_test_server/http_response.h"
 #include "third_party/WebKit/public/web/WebContextMenuData.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 
 using content::ResourceType;
 using content::WebContents;
 
 namespace extensions {
 
 namespace {
 
@@ skipping 260 matching lines @@
     if (throttle)
       throttles->push_back(throttle);
   }
 
  private:
   scoped_refptr<TestNavigationListener> test_navigation_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(TestResourceDispatcherHostDelegate);
 };
 
+// Handles requests for URLs with paths of "/test*" sent to the test server, so
+// tests request a URL that receives a non-error response.
+std::unique_ptr<net::test_server::HttpResponse> HandleTestRequest(
+    const net::test_server::HttpRequest& request) {
+  if (!base::StartsWith(request.relative_url, "/test",
+                        base::CompareCase::SENSITIVE)) {
+    return nullptr;
+  }
+  std::unique_ptr<net::test_server::BasicHttpResponse> response(
+      new net::test_server::BasicHttpResponse());
+  response->set_content("This space intentionally left blank.");
+  return std::move(response);
+}
+
 }  // namespace
 
 class WebNavigationApiTest : public ExtensionApiTest {
  public:
-  WebNavigationApiTest() {}
+  WebNavigationApiTest() {
+    embedded_test_server()->RegisterRequestHandler(
+        base::Bind(&HandleTestRequest));
+  }
   ~WebNavigationApiTest() override {}
 
   void SetUpInProcessBrowserTestFixture() override {
     ExtensionApiTest::SetUpInProcessBrowserTestFixture();
 
     FrameNavigationState::set_allow_extension_scheme(true);
 
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kAllowLegacyExtensionManifests);
 
@@ skipping 68 matching lines @@
 
   // Wait for the extension to set itself up and return control to us.
   ASSERT_TRUE(
       RunExtensionTest("webnavigation/serverRedirectSingleProcess"))
       << message_;
 
   WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
   content::WaitForLoadStop(tab);
 
   ResultCatcher catcher;
-  GURL url(base::StringPrintf(
-      "http://www.a.com:%u/"
-      "extensions/api_test/webnavigation/serverRedirectSingleProcess/a.html",
-      embedded_test_server()->port()));
+  GURL url(
+      base::StringPrintf("http://www.a.com:%u/extensions/api_test/"
+                         "webnavigation/serverRedirectSingleProcess/a.html",
+                         embedded_test_server()->port()));
 
   ui_test_utils::NavigateToURL(browser(), url);
 
   url = GURL(base::StringPrintf(
-      "http://www.b.com:%u/server-redirect?http://www.b.com:%u/",
-      embedded_test_server()->port(),
-      embedded_test_server()->port()));
+      "http://www.b.com:%u/server-redirect?http://www.b.com:%u/test",
+      embedded_test_server()->port(), embedded_test_server()->port()));
 
   ui_test_utils::NavigateToURL(browser(), url);
 
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, ForwardBack) {
   ASSERT_TRUE(StartEmbeddedTestServer());
   ASSERT_TRUE(RunExtensionTest("webnavigation/forwardBack")) << message_;
 }
@@ skipping 325 matching lines @@
           "extensions/api_test/webnavigation/crash/b.html",
       embedded_test_server()->port()));
   ui_test_utils::NavigateToURL(browser(), url);
 
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 #endif
 
 }  // namespace extensions