chrome/test/data/extensions/api_test/runtime/content_script/manifest.json - Issue 2190463008: Add an error page for HTTP 404 error pages without bodies.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/runtime/content_script/manifest.json

Issue 2190463008: Add an error page for HTTP 404 error pages without bodies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc ('K') | « chrome/test/data/errorpage/empty500.html.mock-http-headers ('k') | chrome/test/data/extensions/api_test/webnavigation/serverRedirect/test_serverRedirect.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "API test for the runtime API in content scripts",	2 "name": "API test for the runtime API in content scripts",

3 "version": "1",	3 "version": "1",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "content_scripts": [	5 "content_scripts": [

6 {	6 {

7 "matches": [":///webpage.html"],	7 "matches": [":///echo"],
	Devlin 2016/08/02 16:17:34 Why this change? Why this change? mmenke 2016/08/02 16:27:00 See the change in /extensions/browser/api/runtime/ Show quoted text On 2016/08/02 16:17:34, Devlin wrote: > Why this change? See the change in /extensions/browser/api/runtime/runtime_apitest.cc. There is no webpage.html, and I was sure what the base path of the test server was, so I just used a file the embedded test server provides itself. mmenke 2016/08/02 18:18:33 Looks like this is just using the default path, so Show quoted text On 2016/08/02 16:27:00, mmenke wrote: > On 2016/08/02 16:17:34, Devlin wrote: > > Why this change? > > See the change in /extensions/browser/api/runtime/runtime_apitest.cc. > > There is no webpage.html, and I was sure what the base path of the test server > was, so I just used a file the embedded test server provides itself. Looks like this is just using the default path, so I switched to title1.html. (And the reason why I had to change it is extensions can't run on / otherwise access error pages. I assume this is because error pages have magic internal URLs that don't match the visible URL)
8 "js": ["content_script.js"]	8 "js": ["content_script.js"]

9 }	9 }

10 ]	10 ]

11 }	11 }

OLD	NEW