Revert of Don't clear pending NavigationParams until didStopLoading.

Revert of Don't clear pending NavigationParams until didStopLoading. (patchset #5 id:80001 of https://codereview.chromium.org/2140393002/ )

Reason for revert:
This caused a regression (https://crbug.com/631617).  We'll need to look for a safer way to clear the pending_navigation_params_ and try again.

Original issue's description:
> Don't clear pending NavigationParams until didStopLoading.
>
> Clearing them at the end of NavigateInternal causes problems when a
> ScopedPageLoadDeferrer is in use.
>
> Credit to thestig@ for the test framework changes.
>
> BUG=626838
> TEST=See bug for repro steps.
>
> Committed: https://crrev.com/275d69fc4e8af8ab4a8e7d8fe621ca5b408c134d
> Cr-Commit-Position: refs/heads/master@{#407239}

TBR=avi@chromium.org,thestig@chromium.org,csharrison@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=626838
Committed: https://crrev.com/d356ae14da5ff102779900b23033e2afdb16cccf
Cr-Commit-Position: refs/heads/master@{#408285}

[Charlie Reis, 2016-07-27 21:46:34]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-07-27 21:46:35]

Created Revert of Don't clear pending NavigationParams until didStopLoading.

[commit-bot: I haz the power, 2016-07-27 21:47:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 21:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 21:53:57]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Reis, 2016-07-27 22:33:55]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:34:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-07-27 23:33:24]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-07-27 23:33:28]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:33:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 00:05:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-28 00:07:28]

Description was changed from

==========
Revert of Don't clear pending NavigationParams until didStopLoading. (patchset
#5 id:80001 of https://codereview.chromium.org/2140393002/ )

Reason for revert:
This caused a regression (https://crbug.com/631617).  We'll need to look for a
safer way to clear the pending_navigation_params_ and try again.

Original issue's description:
> Don't clear pending NavigationParams until didStopLoading.
> 
> Clearing them at the end of NavigateInternal causes problems when a
> ScopedPageLoadDeferrer is in use.
> 
> Credit to thestig@ for the test framework changes.
> 
> BUG=626838
> TEST=See bug for repro steps.
> 
> Committed: https://crrev.com/275d69fc4e8af8ab4a8e7d8fe621ca5b408c134d
> Cr-Commit-Position: refs/heads/master@{#407239}

TBR=avi@chromium.org,thestig@chromium.org,csharrison@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=626838
==========

to

==========
Revert of Don't clear pending NavigationParams until didStopLoading. (patchset
#5 id:80001 of https://codereview.chromium.org/2140393002/ )

Reason for revert:
This caused a regression (https://crbug.com/631617).  We'll need to look for a
safer way to clear the pending_navigation_params_ and try again.

Original issue's description:
> Don't clear pending NavigationParams until didStopLoading.
>
> Clearing them at the end of NavigateInternal causes problems when a
> ScopedPageLoadDeferrer is in use.
>
> Credit to thestig@ for the test framework changes.
>
> BUG=626838
> TEST=See bug for repro steps.
>
> Committed: https://crrev.com/275d69fc4e8af8ab4a8e7d8fe621ca5b408c134d
> Cr-Commit-Position: refs/heads/master@{#407239}

TBR=avi@chromium.org,thestig@chromium.org,csharrison@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=626838

Committed: https://crrev.com/d356ae14da5ff102779900b23033e2afdb16cccf
Cr-Commit-Position: refs/heads/master@{#408285}
==========

[commit-bot: I haz the power, 2016-07-28 00:07:29]

Patchset 1 (id:??) landed as
https://crrev.com/d356ae14da5ff102779900b23033e2afdb16cccf
Cr-Commit-Position: refs/heads/master@{#408285}