Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2190453003: Guest mode page visibility patch set 11, minus dom.flush(), w/ overscroll fix (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@UpdateMocha
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guest mode page visibility patch set 11, minus dom.flush(), w/ overscroll fix https://codereview.chromium.org/2106103006/#ps360001 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -50 lines) Patch
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 4 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/compiled_resources2.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/compiled_resources2.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 chunk +18 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 6 chunks +29 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 5 chunks +15 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 2 chunks +45 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/settings_ui/settings_ui_types.js View 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/settings_subpage_browsertest.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
michaelpg
Description was changed from ========== Guest mode page visibility patch set 11, minus dom.flush(), w/ ...
4 years, 4 months ago (2016-07-27 04:55:29 UTC) #1
michaelpg
The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-27 04:55:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190453003/1
4 years, 4 months ago (2016-07-27 04:55:55 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-27 06:38:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-07-27 06:38:53 UTC) #5
michaelpg
4 years, 4 months ago (2016-08-01 15:28:54 UTC) #6 
Description was changed from

==========
Guest mode page visibility patch set 11, minus dom.flush(), w/ overscroll fix

https://codereview.chromium.org/2106103006/#ps360001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Guest mode page visibility patch set 11, minus dom.flush(), w/ overscroll fix

https://codereview.chromium.org/2106103006/#ps360001
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Powered by Google App Engine
This is Rietveld 408576698