Refuse to start if we can't get the user data directory.

Refuse to start if we can't get the user data directory.

The alternative is spewing private user data in random directories.

BUG=22277
TEST=chmod -x ~/.config; Chrome should refuse to start

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27252

[Evan Stade, 2009-09-25 02:10:24]

http://codereview.chromium.org/219043/diff/1/3
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/219043/diff/1/3#newcode77
Line 77: if (!GetDefaultUserDataDirectory(&cur)) {
it appears that this function always returns true..

[tony, 2009-09-25 18:25:05]

There's code currently to use /tmp on linux if we can't get the user data dir. 
Should that be replaced with the CHECK?

[Evan Martin, 2009-09-25 18:33:40]

On 2009/09/25 18:25:05, tony wrote:
> There's code currently to use /tmp on linux if we can't get the user data dir.

> Should that be replaced with the CHECK?

Where's that code?  I wrote this patch by
(a) chmod -x .config
(b) running through a debugger to the first place the path service failed

[Evan Martin, 2009-09-25 19:20:30]

look again

 GetDefaultUserDataDirectory can fail on windows, fwiw

[Evan Stade, 2009-09-25 19:52:14]

ah, so I was confused because the description seems to indicate that you are
testing this on Linux, but that function can't return false on Linux. I guess
it's the create/open directory step that fails, so this seems fine.

[tony, 2009-09-25 19:54:14]

LGTM