[DevTools] Replace InjectedScriptHost.suppressWarningsAndCallFunction with hasOwnProperty.

[DevTools] Replace InjectedScriptHost.suppressWarningsAndCallFunction with hasOwnProperty.

BUG=none

Committed: https://crrev.com/b7cb4fa32447214da8761c96c32fc4288e3b2cc3
Cr-Commit-Position: refs/heads/master@{#408848}

[dgozman, 2016-07-29 19:09:03]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2016-07-29 19:09:04]

Could you please take a look?

[kozy, 2016-07-29 22:11:55]

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:118: if
(!InjectedScriptHost.hasOwnProperty(/** @type {?Object} */ (obj), "length"))
Please align this type with externs. It's !Object there.

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:625:
return /** @type {string} */ (obj.toString()) || "Symbol";
please remove /** @type {string} */

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
(right):

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js:42: *
@param {!Object} object
I think we need to rename this method to solve closure error:
WARNING - mismatch of the hasOwnProperty property type and the type of the
property it overrides from superclass Object
original: function (this:Object, *): boolean
override: function (this:InjectedScriptHostClass, Object, string): boolean
InjectedScriptHostClass.prototype.hasOwnProperty = function(object,
propertyName) {}

[dgozman, 2016-07-29 23:30:26]

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:118: if
(!InjectedScriptHost.hasOwnProperty(/** @type {?Object} */ (obj), "length"))
On 2016/07/29 22:11:55, kozyatinskiy wrote:
> Please align this type with externs. It's !Object there.

Done.

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:625:
return /** @type {string} */ (obj.toString()) || "Symbol";
On 2016/07/29 22:11:55, kozyatinskiy wrote:
> please remove /** @type {string} */

Done.

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js
(right):

https://codereview.chromium.org/2190353004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js:42: *
@param {!Object} object
On 2016/07/29 22:11:55, kozyatinskiy wrote:
> I think we need to rename this method to solve closure error:
> WARNING - mismatch of the hasOwnProperty property type and the type of the
> property it overrides from superclass Object
> original: function (this:Object, *): boolean
> override: function (this:InjectedScriptHostClass, Object, string): boolean
> InjectedScriptHostClass.prototype.hasOwnProperty = function(object,
> propertyName) {}

Done.

[dgozman, 2016-07-29 23:30:39]

Please take another look.

[kozy, 2016-07-30 01:28:34]

lgtm

[kozy, 2016-07-30 01:30:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:30:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 02:47:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 02:49:23]

Description was changed from

==========
[DevTools] Replace InjectedScriptHost.suppressWarningsAndCallFunction with
hasOwnProperty.

BUG=none
==========

to

==========
[DevTools] Replace InjectedScriptHost.suppressWarningsAndCallFunction with
hasOwnProperty.

BUG=none

Committed: https://crrev.com/b7cb4fa32447214da8761c96c32fc4288e3b2cc3
Cr-Commit-Position: refs/heads/master@{#408848}
==========

[commit-bot: I haz the power, 2016-07-30 02:49:24]

Patchset 2 (id:??) landed as
https://crrev.com/b7cb4fa32447214da8761c96c32fc4288e3b2cc3
Cr-Commit-Position: refs/heads/master@{#408848}