src/base/atomic-utils.h - Issue 2190333002: Teach compiler jobs how to actually parse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/atomic-utils.h

Issue 2190333002: Teach compiler jobs how to actually parse (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/base/atomic-utils.h

diff --git a/src/base/atomic-utils.h b/src/base/atomic-utils.h

index ac90fd98a7130a2ec26ca6680f9c2acad3f08a57..6731a810f18c06f7929c21e2ec9c7f5466bccbe0 100644

--- a/src/base/atomic-utils.h

+++ b/src/base/atomic-utils.h

@@ -52,7 +52,7 @@ class AtomicValue {

explicit AtomicValue(T initial)

: value_(cast_helper<T>::to_storage_type(initial)) {}

- V8_INLINE T Value() {

+ V8_INLINE T Value() const {

return cast_helper<T>::to_return_type(base::Acquire_Load(&value_));

}