Teach compiler jobs how to actually parse

src/compiler-dispatcher/compiler-dispatcher-job.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_JOB_H_
 #define V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_JOB_H_
 
 #include <memory>
 
+#include "src/base/atomic-utils.h"
 #include "src/base/macros.h"
 #include "src/handles.h"
 
 namespace v8 {
 namespace internal {
 
 class CompilationInfo;
 class Isolate;
 class JSFunction;
 class ParseInfo;
+class Parser;
 class UnicodeCache;
 class Utf16CharacterStream;
 class Zone;
 
 enum class CompileJobStatus {
   kInitial,
   kReadyToParse,
+  kParsed,
 };
 
 class CompilerDispatcherJob {
  public:
-  CompilerDispatcherJob(Isolate* isolate, Handle<JSFunction> function);
+  CompilerDispatcherJob(Isolate* isolate, Handle<JSFunction> function,
+                        size_t max_stack_size);
   ~CompilerDispatcherJob();
 
-  CompileJobStatus status() const { return status_; }
+  CompileJobStatus status() const { return status_.Value(); }
+  bool can_parse_on_background_thread() const {
+    return can_parse_on_background_thread_;
+  }
 
   // Transition from kInitial to kReadyToParse.
   void PrepareToParseOnMainThread();
 
+  // Transition from kReadyToParse to kParsed.
+  void Parse();
+
  private:
-  CompileJobStatus status_ = CompileJobStatus::kInitial;
+  base::AtomicValue<CompileJobStatus> status_ =
+      base::AtomicValue<CompileJobStatus>(CompileJobStatus::kInitial);

[vogelheim, 2016/07/29 10:19:56]

Why initialize here, and not in constructor?

[jochen (gone - plz use gerrit), 2016/07/29 10:27:45]

so you see in the header that this is independend of the ctor parameters

   Isolate* isolate_;
   Handle<JSFunction> function_;  // Global handle.
+  size_t max_stack_size_;
 
   // Members required for parsing.
   std::unique_ptr<UnicodeCache> unicode_cache_;
   std::unique_ptr<Zone> zone_;
   std::unique_ptr<Utf16CharacterStream> character_stream_;
   std::unique_ptr<ParseInfo> parse_info_;
+  std::unique_ptr<Parser> parser_;
 
   bool can_parse_on_background_thread_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilerDispatcherJob);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_JOB_H_