Issue 219032: Mac: Sheets should be positioned between the content and everything above it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219032: Mac: Sheets should be positioned between the content and everything above it. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Sheets should be positioned between the content and everything above it. BUG=17615 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27378

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

No... unless we switch the sheet to use the tab modal sheet machinery then it's ...

11 years, 3 months ago (2009-09-24 18:56:49 UTC) #2

John Grabowski

11 years, 3 months ago (2009-09-24 20:05:48 UTC) #3

I like erg's change, but discussion moved to http://crbug.com/17615.

jrg

On Thu, Sep 24, 2009 at 11:56 AM, <avi@chromium.org> wrote:

> No... unless we switch the sheet to use the tab modal sheet machinery then
> it's
> a window-modal sheet and we shouldn't put it into a position where it looks
> tab-modal.
>
>
> http://codereview.chromium.org/219032
>

Expand Messages | Collapse Messages