src/mips/lithium-codegen-mips.cc - Issue 21903003: MIPS: Avoid redundant smi check for Math.abs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 21903003: MIPS: Avoid redundant smi check for Math.abs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index 01671143ab62114aa5926bdf14a09e0ed20282b1..810b16e3489b380c4f2fc92a0c7a957f6ade5f2e 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -3652,7 +3652,7 @@ void LCodeGen::DoMathAbs(LMathAbs* instr) {

FPURegister input = ToDoubleRegister(instr->value());

FPURegister result = ToDoubleRegister(instr->result());

__ abs_d(result, input);

- } else if (r.IsInteger32()) {

+ } else if (r.IsSmiOrInteger32()) {

EmitIntegerMathAbs(instr);

} else {

// Representation is tagged.

« no previous file with comments | « no previous file | no next file » | no next file with comments »