Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2190293004: Remove myself from OWNERS and histograms.xml. (Closed)

Created:
4 years, 4 months ago by dzhioev (left Google)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, asvitkine+watch_chromium.org, michaelpg+watch-polymer_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove myself from OWNERS and histograms.xml. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5b1eadad78d461013615c96d1a414211882b2f57 Cr-Commit-Position: refs/heads/master@{#408907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M chrome/browser/chromeos/first_run/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/reset/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/first_run/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/pairing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/session_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/user_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/web-animations-js/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/polymer/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/login/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
dzhioev (left Google)
Hi, please review
4 years, 4 months ago (2016-07-30 01:17:28 UTC) #4
Dan Beam
so long and thanks for all the fish! lgtm
4 years, 4 months ago (2016-07-30 01:19:30 UTC) #6
Alexander Alekseev
lgtm
4 years, 4 months ago (2016-07-30 01:20:57 UTC) #7
michaelpg
lgtm, thank you Pasha
4 years, 4 months ago (2016-07-30 19:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190293004/1
4 years, 4 months ago (2016-07-30 19:35:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/228284)
4 years, 4 months ago (2016-07-30 19:41:30 UTC) #12
achuithb
components/pairing/OWNERS lgtm
4 years, 4 months ago (2016-07-31 02:25:29 UTC) #14
achuithb
Ilya, need lgtm for histograms
4 years, 4 months ago (2016-07-31 02:25:58 UTC) #16
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-08-01 02:51:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190293004/1
4 years, 4 months ago (2016-08-01 02:52:19 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 04:04:34 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 04:06:42 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b1eadad78d461013615c96d1a414211882b2f57
Cr-Commit-Position: refs/heads/master@{#408907}

Powered by Google App Engine
This is Rietveld 408576698