Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2190293002: Stop TextCheckingHelper from checking grammar (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop TextCheckingHelper from checking grammar This patch removes grammar checking related code from TextCheckingHelper because Chromium and Blink do not support grammar checking. The related public member functions still keep the same signatures but no longer perform any grammar checking or return any grammar mistake. TextCheckerClient::checkGrammarOfString() is also removed since it is only used by TextCheckingHelper. BUG=619452 TEST=n/a; no visible behavior change Committed: https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b Cr-Commit-Position: refs/heads/master@{#408594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -220 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 8 chunks +7 lines, -180 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextCheckerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Xiaocheng
PTAL. There will be a separate patch cleaning up the public functions of |TextCheckingHelper| after ...
4 years, 4 months ago (2016-07-29 05:33:37 UTC) #4
yosin_UTC9
lgtm
4 years, 4 months ago (2016-07-29 05:43:50 UTC) #5
tkent
lgtm
4 years, 4 months ago (2016-07-29 05:46:30 UTC) #6
Xiaocheng
Thanks for the review.
4 years, 4 months ago (2016-07-29 06:24:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190293002/1
4 years, 4 months ago (2016-07-29 06:24:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 06:55:15 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 06:58:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b
Cr-Commit-Position: refs/heads/master@{#408594}

Powered by Google App Engine
This is Rietveld 408576698