Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2190283003: Fix a FPE in CStretchEngine::StartStretchHorz(). (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix a FPE in CStretchEngine::StartStretchHorz(). Do some cleanup in the process. BUG=629839 Committed: https://pdfium.googlesource.com/pdfium/+/246221724a106c11481eedbf1f94475afba23569

Patch Set 1 #

Total comments: 2

Patch Set 2 : signed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -36 lines) Patch
M core/fxge/dib/dib_int.h View 4 chunks +13 lines, -7 lines 0 comments Download
M core/fxge/dib/fx_dib_engine.cpp View 1 4 chunks +38 lines, -29 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Lei Zhang
4 years, 4 months ago (2016-07-29 14:56:26 UTC) #6
Oliver Chang
lgtm https://codereview.chromium.org/2190283003/diff/1/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2190283003/diff/1/core/fxge/dib/fx_dib_engine.cpp#newcode372 core/fxge/dib/fx_dib_engine.cpp:372: m_SrcClip.Height() > (int)((1U << 29) / m_InterPitch)) { ...
4 years, 4 months ago (2016-07-29 16:35:06 UTC) #7
Lei Zhang
https://codereview.chromium.org/2190283003/diff/1/core/fxge/dib/fx_dib_engine.cpp File core/fxge/dib/fx_dib_engine.cpp (right): https://codereview.chromium.org/2190283003/diff/1/core/fxge/dib/fx_dib_engine.cpp#newcode372 core/fxge/dib/fx_dib_engine.cpp:372: m_SrcClip.Height() > (int)((1U << 29) / m_InterPitch)) { On ...
4 years, 4 months ago (2016-07-29 19:16:04 UTC) #8
Oliver Chang
lgtm++
4 years, 4 months ago (2016-07-29 20:37:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190283003/20001
4 years, 4 months ago (2016-07-29 20:38:40 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 20:38:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/246221724a106c11481eedbf1f94475afba2...

Powered by Google App Engine
This is Rietveld 408576698