Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2190283002: 🚲 Fix android_aar resources causing lint warnings (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android_aar resources causing lint warnings Just needed to make the aar's java_prebuilt targets depend on the resource targets so that would be deemed the resource owners within write_build_config.py BUG=632362 Committed: https://crrev.com/0d2b6f00cd29a9ac44af44212a8f53cd0e0c9de3 Cr-Commit-Position: refs/heads/master@{#408798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M build/config/android/rules.gni View 3 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
agrieve
On 2016/07/29 03:54:37, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:ianwen@chromium.org
4 years, 4 months ago (2016-07-29 03:54:44 UTC) #4
Ian Wen
lgtm Aha this time I do understand the code. Thank you for the fix!
4 years, 4 months ago (2016-07-29 23:05:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190283002/1
4 years, 4 months ago (2016-07-29 23:05:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 23:10:15 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:12:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2b6f00cd29a9ac44af44212a8f53cd0e0c9de3
Cr-Commit-Position: refs/heads/master@{#408798}

Powered by Google App Engine
This is Rietveld 408576698