Issue 219023010: Mojo: RawSharedBuffer::Mapping -> RawSharedBufferMapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219023010: Mojo: RawSharedBuffer::Mapping -> RawSharedBufferMapping. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: RawSharedBuffer::Mapping -> RawSharedBufferMapping. Because the former can't be forward-declared, which leads to raw_shared_buffer.h being included into just about everything, which kind of sucks. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260760

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -82 lines)			Patch
M	mojo/system/core_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/dispatcher.h	View		4 chunks	+3 lines, -5 lines	0 comments	Download
M	mojo/system/dispatcher.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/system/dispatcher_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/system/raw_shared_buffer.h	View		5 chunks	+42 lines, -32 lines	0 comments	Download
M	mojo/system/raw_shared_buffer.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	mojo/system/raw_shared_buffer_posix.cc	View		3 chunks	+11 lines, -10 lines	0 comments	Download
M	mojo/system/raw_shared_buffer_unittest.cc	View		7 chunks	+9 lines, -9 lines	0 comments	Download
M	mojo/system/raw_shared_buffer_win.cc	View	1	3 chunks	+11 lines, -10 lines	0 comments	Download
M	mojo/system/shared_buffer_dispatcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/shared_buffer_dispatcher.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/system/shared_buffer_dispatcher_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

6 years, 8 months ago (2014-04-01 02:44:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r260760 (presubmit successful).