Issue 219023004: Revert of Increase the broken tests threshold from 10 to 20

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219023004: Revert of Increase the broken tests threshold from 10 to 20 (Closed)

Created:
6 years, 8 months ago by giannis_vela

Modified:
6 years, 8 months ago

Reviewers:
phajdan, sky, Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Increase the broken tests threshold from 10 to 20 (https://codereview.chromium.org/219383002/) Reason for revert: is Original issue's description: > Increase the broken tests threshold from 10 to 20 > > BUG=none > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260539 TBR=sky@chromium.org,phajdan@google.com,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Created: 6 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/test/launcher/test_launcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

giannis_vela

Created Revert of Increase the broken tests threshold from 10 to 20

6 years, 8 months ago (2014-03-31 13:50:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/giannis_vela@yahoo.gr/219023004/1

6 years, 8 months ago (2014-03-31 13:50:43 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-03-31 13:50:44 UTC) #3

commit-bot: I haz the power

6 years, 8 months ago (2014-03-31 13:50:44 UTC) #4

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages