Issue 21902002: Support synchronous mode in WebFileWriterImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21902002: Support synchronous mode in WebFileWriterImpl (Closed)

Created:
7 years, 4 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
michaeln, tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support synchronous mode in WebFileWriterImpl BUG=257349 TEST=no behavioral change yet R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215787

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -12 lines)			Patch
M	content/child/fileapi/webfilesystem_impl.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/child/fileapi/webfilewriter_impl.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/child/fileapi/webfilewriter_impl.cc	View		5 chunks	+45 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

kinuko

Similar change to https://codereview.chromium.org/21091007/. Can you take a look? (Hopefully this is the last non-trivial ...

7 years, 4 months ago (2013-08-05 01:20:37 UTC) #1

kinuko

7 years, 4 months ago (2013-08-06 04:00:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r215787 (presubmit successful).