Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 219017: Create the download folder if it doesn't exist. That is, the actual download ... (Closed)

Created:
11 years, 3 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Create the download folder if it doesn't exist. That is, the actual download folder, not the default one. BUG=21759 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27266

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -53 lines) Patch
M chrome/browser/download/save_file_manager.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/download/save_file_manager.cc View 29 chunks +44 lines, -34 lines 0 comments Download
M chrome/browser/download/save_package.h View 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/download/save_package.cc View 1 2 3 6 chunks +30 lines, -14 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
11 years, 3 months ago (2009-09-23 20:46:36 UTC) #1
Evan Stade
http://codereview.chromium.org/219017/diff/1/4 File chrome/browser/download/save_package.cc (right): http://codereview.chromium.org/219017/diff/1/4#newcode1061 Line 1061: if (!file_util::DirectoryExists(save_dir)) can just do CreateDirectory http://codereview.chromium.org/219017/diff/1/4#newcode1062 Line ...
11 years, 3 months ago (2009-09-23 22:05:55 UTC) #2
Lei Zhang
Everything's on the right thread now. I dropped the changes to the options dialog, which ...
11 years, 3 months ago (2009-09-24 22:49:25 UTC) #3
Evan Stade
LGTM
11 years, 3 months ago (2009-09-24 23:10:01 UTC) #4
Lei Zhang
Added InternalInit(), turns out the try server ui test failure was not a flake.
11 years, 3 months ago (2009-09-25 04:48:32 UTC) #5
Evan Stade
11 years, 3 months ago (2009-09-25 18:19:19 UTC) #6
ok

Powered by Google App Engine
This is Rietveld 408576698